Use correct slot for COUNTKEYSINSLOT command #3327
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndyakov
requested changes
Mar 31, 2025
There was a problem hiding this comment.
@khasanovbi thank you for the contribution! Are there other commands that need to be executed on the args[2] slot? If so, let's prepare a slice and check if the arg[1] is in this list. Also, let's add tests for the change.
khasanovbi
force-pushed
the
count_keys_in_slot
branch
from
0c0aa56 to
bb7c519
Compare
|
Hi @ndyakov I'm checked other commands in docs and don't think that there are other commands that should use slot from command arg. About the tests, I found ClusterGetKeysInSlot, ClusterCountKeysInSlot tests in osscluster_test.go only. |
|
Hey @khasanovbi , I would expect to see a unit test for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.